Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't insert extra close bracket when the cursor is already on top of one #2171

Closed
byorgey opened this issue Oct 12, 2024 · 0 comments · Fixed by #2215
Closed

Don't insert extra close bracket when the cursor is already on top of one #2171

byorgey opened this issue Oct 12, 2024 · 0 comments · Fixed by #2215
Assignees
@byorgey
Labels
C-Low Hanging Fruit Ideal issue for new contributors. G-REPL An issue having to do with the REPL. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. T-UI Involves the user interface. Z-Feature A new feature to be added to the game.

Comments

@byorgey
Copy link
Member

byorgey commented Oct 12, 2024

With #1953 , at the REPL we now automatically insert a matching close bracket when typing an open paren, square bracket, or curly brace. To go along with this, it would be nice if the REPL did not insert an extra close bracket when you type one but the cursor is already on top of one --- it should just move the cursor one space to the right instead.

For example, suppose you type open paren, x, +, y, close paren. Right now you would end up with

(x+y)|)

(where | indicates the cursor position) but I would like to end up with

(x+y)|
@byorgey byorgey added the Z-Feature A new feature to be added to the game. label Oct 12, 2024
@byorgey byorgey added T-UI Involves the user interface. G-REPL An issue having to do with the REPL. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. C-Low Hanging Fruit Ideal issue for new contributors. labels Nov 25, 2024
@byorgey byorgey self-assigned this Nov 25, 2024
byorgey added a commit that referenced this issue Nov 25, 2024
@byorgey
just move past existing close bracket chars when typing them
4e2f716 
Closes #2171.
@byorgey byorgey mentioned this issue Nov 25, 2024
Merged
@mergify mergify bot closed this as completed in #2215 Nov 28, 2024
@mergify mergify bot closed this as completed in c7678f3 Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@byorgey byorgey

Labels
C-Low Hanging Fruit Ideal issue for new contributors. G-REPL An issue having to do with the REPL. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. T-UI Involves the user interface. Z-Feature A new feature to be added to the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't insert extra close bracket when the cursor is already on top of one swarm-game/swarm
1 participant
@byorgey