Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Children of system robots do not bypass device requirements #1664

Closed
kostmo opened this issue Nov 26, 2023 · 3 comments · Fixed by #1819
Closed

Children of system robots do not bypass device requirements #1664

kostmo opened this issue Nov 26, 2023 · 3 comments · Fixed by #1819
Labels
Bug The observed behaviour is incorrect or unexpected.

Comments

@kostmo
Copy link
Member

kostmo commented Nov 26, 2023

Normally, system robots are not required to possess devices in order to use any particular command.

However, a robot built by a system robot becomes subject to the requirement (see worker bee code in #1599).

Also related: #1430
@kostmo kostmo added the Bug The observed behaviour is incorrect or unexpected. label Nov 26, 2023
@kostmo kostmo mentioned this issue Nov 26, 2023
Closed
@byorgey
Copy link
Member

byorgey commented Nov 28, 2023

Strange. We are correctly setting children of system robots to also be system robots (

swarm/src/Swarm/Game/Step.hs

Line 1988 in 44c2e60

isSystemRobot
) so I'm not sure what would cause this. Do you have a simple minimal example to reproduce this behavior?

@kostmo kostmo mentioned this issue Dec 9, 2023
Merged
@kostmo
Copy link
Member Author

kostmo commented Dec 9, 2023

Do you have a simple minimal example to reproduce this behavior?

Test case created in #1677.

@byorgey
Copy link
Member

byorgey commented Dec 13, 2023

A random thought I just had while reviewing #1677 : it might have something to do with the dynamic checks we do when building child robots. We should look into the logic used to determine which devices need to be installed when executing build.

mergify bot pushed a commit that referenced this issue Dec 13, 2023
@kostmo
Inventory requirements for child robots of system robots (#1677)
1bcd050 
Towards #1664.

This PR adds a failing unit test.
@kostmo kostmo mentioned this issue May 3, 2024
Merged
@mergify mergify bot closed this as completed in #1819 May 4, 2024
mergify bot pushed a commit that referenced this issue May 4, 2024
@kostmo
Fix child robot privileges (#1819)
e39255f 
Fixes #1664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug The observed behaviour is incorrect or unexpected.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix child robot privileges swarm-game/swarm
2 participants
@kostmo @byorgey