Include process NODE_ENV in archive hash. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this will invalidate existing caches, can you submit PR where this is an option to install? Something like |
|
I would argue that invalidating existing caches in this case is desirable (as currently they could be wrong) - especially as users of |
|
What about this pull request? I just stepped on this when found out that my devDependencies can never be installed : ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the packages installed (devDependencies when not on
production) differ based on environment, the hash should include the process's environment.Not doing this causes an issue with servers that have multiple environments running for one particular module. For example, I have
stagingandproductioninstallations of a repository on the same server, but run under different environments. If I installproductionbeforestaging, the devDependencies will never be installed.