Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_add_subparsers_twice with Python 3.12.5 #146

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

shadchin
Copy link
Contributor

No description provided.

@martinjm97
Copy link
Collaborator

Hi @shadchin, thank you for the contribution! Do you happen to have a reference to the change in Python 3.12.5 and a reason for why it will persist to future versions of Python?

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.07%. Comparing base (b569790) to head (d7f7f9d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   94.07%   94.07%           
=======================================
  Files           4        4           
  Lines         692      692           
=======================================
  Hits          651      651           
  Misses         41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shadchin
Copy link
Contributor Author

Hi @shadchin, thank you for the contribution! Do you happen to have a reference to the change in Python 3.12.5 and a reason for why it will persist to future versions of Python?

python/cpython#121018

@martinjm97
Copy link
Collaborator

Perfect! Thank you!

@martinjm97 martinjm97 merged commit 5257fe8 into swansonk14:main Aug 12, 2024
17 checks passed
@shadchin shadchin deleted the patch-1 branch August 14, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants