Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support enums on array parameters #919

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

j-sv
Copy link
Contributor

@j-sv j-sv commented Apr 20, 2021

Describe the PR
Adds support for including enums on array query parameters. If the parameter type is an array, the enum values are added to the items field on the parameter instead.

Relation issue
#918

Additional context
None

Adds support for including enums on array query parameters. If the
parameter type is an array, the enum values are added to the item field
on the parameter instead.
Copy link
Member

@sdghchj sdghchj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j-sv
Copy link
Contributor Author

j-sv commented Apr 21, 2021

Thanks @sdghchj! Do I need to do anything further to trigger the CI checks?

@lorenzodonini
Copy link

I've been using this PR for a production setup and it works very well so far. Would love to have this on the main repo branch. Any idea, when this can be merged?

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit e8632e2 into swaggo:master Jul 27, 2021
@ubogdan
Copy link
Contributor

ubogdan commented Jul 27, 2021

@lorenzodonini Thanks for your contribution!

@j-sv j-sv deleted the support-query-array-enums branch August 2, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants