Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and fix tests #835

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Conversation

akojo
Copy link
Contributor

@akojo akojo commented Nov 18, 2020

Describe the PR

Upgrade github.com/go-openapi/spec and golang.org/x/tools to latest
versions.

Upgrading github.com/go-openapi/spec v0.19.11 -> v.0.19.14 generates
empty "description" members for responses and empty "authorizationUrl"
members for securityDefinitions when they're missing. This causes tests
to fail. Fix by adding the missing empty definitions to expected test
results.

Additional context
Since travis-ci test builds always fetch deps and build before running tests,
they break because of the change in go-openapi/spec

Upgrade github.com/go-openapi/spec and golang.org/x/tools to latest
versions.

Upgrading github.com/go-openapi/spec v0.19.11 -> v.0.19.14 generates
empty "description" members for responses and empty "authorizationUrl"
members for securityDefinitions when they're missing. This causes tests
to fail. Fix by adding the missing empty definitions to expected test
results.
@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #835 (af42bf7) into master (3f47d68) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #835      +/-   ##
==========================================
- Coverage   82.53%   82.41%   -0.13%     
==========================================
  Files           8        8              
  Lines        1626     1626              
==========================================
- Hits         1342     1340       -2     
- Misses        168      169       +1     
- Partials      116      117       +1     
Impacted Files Coverage Δ
parser.go 78.73% <0.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f47d68...af42bf7. Read the comment docs.

@sdghchj
Copy link
Member

sdghchj commented Nov 19, 2020

I just can't figure out why it generates empty members?

@akojo
Copy link
Contributor Author

akojo commented Nov 19, 2020

According to the spec description and authorizationUrl are required fields in those contexts. Apparently that's the reason they are now always included

@sdghchj
Copy link
Member

sdghchj commented Nov 19, 2020

According to the spec description and authorizationUrl are required fields in those contexts. Apparently that's the reason they are now always included

So where is it that the member description is set required, I mean in source code?

@akojo
Copy link
Contributor Author

akojo commented Nov 19, 2020

So where is it that the member description is set required, I mean in source code?

Here's in spec the commit that always generates those two members. Apparently it's included in version 0.19.13 and onwards

@sdghchj
Copy link
Member

sdghchj commented Nov 19, 2020

So where is it that the member description is set required, I mean in source code?

Here's in spec the commit that always generates those two members. Apparently it's included in version 0.19.13 and onwards

OK I see.
But, as you memtioned that it's included in version 0.19.13, however, I just upgrade it to v0.19.12, it still failed when running those tests. Refer to https://github.com/swaggo/swag/pull/836/checks?check_run_id=1422025199

Copy link
Member

@sdghchj sdghchj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdghchj sdghchj merged commit 2ca4d38 into swaggo:master Nov 19, 2020
@sdghchj
Copy link
Member

sdghchj commented Nov 19, 2020

@akojo Thank you all the same.

@akojo akojo deleted the update-deps branch April 12, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants