-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and fix tests #835
Conversation
Upgrade github.com/go-openapi/spec and golang.org/x/tools to latest versions. Upgrading github.com/go-openapi/spec v0.19.11 -> v.0.19.14 generates empty "description" members for responses and empty "authorizationUrl" members for securityDefinitions when they're missing. This causes tests to fail. Fix by adding the missing empty definitions to expected test results.
Codecov Report
@@ Coverage Diff @@
## master #835 +/- ##
==========================================
- Coverage 82.53% 82.41% -0.13%
==========================================
Files 8 8
Lines 1626 1626
==========================================
- Hits 1342 1340 -2
- Misses 168 169 +1
- Partials 116 117 +1
Continue to review full report at Codecov.
|
I just can't figure out why it generates empty members? |
According to the spec |
So where is it that the member |
Here's in spec the commit that always generates those two members. Apparently it's included in version 0.19.13 and onwards |
OK I see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@akojo Thank you all the same. |
Describe the PR
Upgrade github.com/go-openapi/spec and golang.org/x/tools to latest
versions.
Upgrading github.com/go-openapi/spec v0.19.11 -> v.0.19.14 generates
empty "description" members for responses and empty "authorizationUrl"
members for securityDefinitions when they're missing. This causes tests
to fail. Fix by adding the missing empty definitions to expected test
results.
Additional context
Since travis-ci test builds always fetch deps and build before running tests,
they break because of the change in go-openapi/spec