Ignore swag file from root dir only #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule `swag` matches not only file in main directory but also folder in `cmd/swag`. I've changed it to match only in current folder. For visual I've changed also `swag.exe`. I've run into issue when I tried to vendor sources for swag but also for tool. The main.go got ignored by git, I was required to `git add -f vendor/github.com/swaggo/swag/cmd/swag/main.go`
Codecov Report
@@ Coverage Diff @@
## master #775 +/- ##
=======================================
Coverage 82.16% 82.16%
=======================================
Files 8 8
Lines 1744 1744
=======================================
Hits 1433 1433
Misses 193 193
Partials 118 118 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
The
.gitignoreruleswagmatches not only file in main directory but also folder incmd/swag.I've changed it to match only in current folder. For visual I've changed also
swag.exe.Additional context
I've run into the issue when I tried to vendor sources for swag but also for tool. The
main.gogot ignored by git, I've forced git to add it withgit add -f vendor/github.com/swaggo/swag/cmd/swag/main.gohttps://git-scm.com/docs/gitignore#_pattern_format