Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required docs to README.md #703

Merged
merged 2 commits into from
May 29, 2020
Merged

Conversation

sdowding-koho
Copy link
Contributor

Describe the PR
There is no mention of the validate tag used for required fields in the docs, so I did my best to add one.

Relation issue
None

Additional context
To help people who come after me!

There is no mention of the `validate` tag used for required fields in the docs, so I did my best to add one.
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2020

Codecov Report

Merging #703 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #703   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files           7        7           
  Lines        1859     1859           
=======================================
  Hits         1576     1576           
  Misses        177      177           
  Partials      106      106           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d963c...2eeeca7. Read the comment docs.

@sdowding-koho
Copy link
Contributor Author

anything I can do to help get this merged?

@easonlin404
Copy link
Member

@sdowding-koho sorry for the late reply, LGTM.

@easonlin404 easonlin404 merged commit 51088c1 into swaggo:master May 29, 2020
@easonlin404
Copy link
Member

Thanks for your contribution. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants