Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed definition parsing for alias types #1688

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

artem328
Copy link

Describe the PR
The fix for OpenAPI v3 definition parsing of go alias types

Relation issue
#1590

Additional context

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0709499) 79.17% compared to head (0bd768d) 79.21%.

❗ Current head 0bd768d differs from pull request most recent head 5cc33be. Consider uploading reports for the commit 5cc33be to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #1688      +/-   ##
==========================================
+ Coverage   79.17%   79.21%   +0.03%     
==========================================
  Files          21       21              
  Lines        5605     5605              
==========================================
+ Hits         4438     4440       +2     
+ Misses        991      989       -2     
  Partials      176      176              
Files Coverage Δ
parserv3.go 72.54% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonklingele
Copy link

Fixes the issue for me! Thanks 😊

@ubogdan ubogdan merged commit 37dac67 into swaggo:v2 Nov 7, 2023
8 checks passed
@ubogdan
Copy link
Contributor

ubogdan commented Nov 7, 2023

@artem328 Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants