Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if the top type name is any or interface{}, don't use allOf #1421

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Dec 13, 2022

Describe the PR
If the top type name in response is any or interface{}, don't use allOf. This will make it more readable.

Relation issue
#1413

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 85.16% // Head: 85.17% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (0330cbd) compared to base (dfce6c8).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 0330cbd differs from pull request most recent head eaaa741. Consider uploading reports for the commit eaaa741 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1421      +/-   ##
==========================================
+ Coverage   85.16%   85.17%   +0.01%     
==========================================
  Files          19       19              
  Lines        3613     3616       +3     
==========================================
+ Hits         3077     3080       +3     
  Misses        458      458              
  Partials       78       78              
Impacted Files Coverage Δ
operation.go 96.11% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ubogdan ubogdan merged commit 566b8af into master Feb 22, 2023
@ubogdan ubogdan deleted the resp-combined-optimize branch February 22, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants