fix: don't error on empty comment line in matchExtension #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorkova
changed the title
Codecov ReportBase: 85.22% // Head: 85.23% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1415 +/- ##
=======================================
Coverage 85.22% 85.23%
=======================================
Files 19 19
Lines 3635 3636 +1
=======================================
+ Hits 3098 3099 +1
Misses 459 459
Partials 78 78
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
igorkova
force-pushed
the
fix-parseextension-empty-comment
branch
from
db17bf9
to
17965fd
Compare
ubogdan
approved these changes
Dec 12, 2022
|
@igorkova Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
parseExtension will break on empty comment lines
//Relation issue
#1219
Additional context
My previous test cases weren't covering empty comment lines and in that case
fields[0]breaks.Added fix and tests.
More than open for further suggestions/improvements if there are any