chore: Remove gomonkey dependency from formatter #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akojo
force-pushed
the
chore/remove-gomonkey
branch
from
9ceda39
to
f8a6d34
Compare
Move directory tree walking code from Formatter to format/ package that handles `fmt` subcommand.
akojo
force-pushed
the
chore/remove-gomonkey
branch
from
f8a6d34
to
f7c67c6
Compare
- Handle file open/read/update in format/format.go - Only handle formatting file contents in formatter.go - Write tests against formatter public API only - Clean up formatter code
akojo
force-pushed
the
chore/remove-gomonkey
branch
from
f7c67c6
to
bbbb6c5
Compare
|
@ubogdan have you seen this one before with CI tests? # cd .; git clone -- https://go.googlesource.com/lint /home/runner/work/swag/src/golang.org/x/lint
Cloning into '/home/runner/work/swag/src/golang.org/x/lint'...
fatal: unable to access 'https://go.googlesource.com/lint/': The requested URL returned error: 502
package golang.org/x/lint/golint: exit status 128I couldn't reproduce locally |
Codecov Report
@@ Coverage Diff @@
## master #1192 +/- ##
==========================================
- Coverage 95.03% 94.70% -0.33%
==========================================
Files 10 11 +1
Lines 2557 2475 -82
==========================================
- Hits 2430 2344 -86
- Misses 69 71 +2
- Partials 58 60 +2
Continue to review full report at Codecov.
|
|
@akojo looks like a temporary issue. |
|
Coverage test seems to be failing because decreasing the amount of code lines in the repo brings overall coverage down. |
|
@akojo Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Refactor formatter file handling code so that formatter itself and the
fmtcommand-line tool can be tested without usinggomonkey.Implement formatter tests so that they tests against actual pieces of go code with comments. While doing that clean up formatter code so that it's 100% covered by tests.
Relation issue
#1178