Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Go 1.18 (with support for the new any keyword) #1168

Merged
merged 6 commits into from
Mar 30, 2022
Merged

Bump to Go 1.18 (with support for the new any keyword) #1168

merged 6 commits into from
Mar 30, 2022

Conversation

applejag
Copy link
Contributor

Describe the PR
These are @rdlaitila's changes to make swaggo work with Go 1.18. Their changes are 2 weeks old, and so I thought to push @rdlaitila's changes and put effort in adjusting it for any review comments.

Relation issue
Closes #1162

Additional context
I do not know who @rdlaitila is, I just found their changes mentioned in the related issue.

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #1168 (06c66d5) into master (2b64f78) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 06c66d5 differs from pull request most recent head 6269dae. Consider uploading reports for the commit 6269dae to get more accurate results

@@           Coverage Diff           @@
##           master    #1168   +/-   ##
=======================================
  Coverage   94.76%   94.77%           
=======================================
  Files          10       10           
  Lines        2447     2449    +2     
=======================================
+ Hits         2319     2321    +2     
  Misses         67       67           
  Partials       61       61           
Impacted Files Coverage Δ
operation.go 96.01% <100.00%> (+0.01%) ⬆️
schema.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b64f78...6269dae. Read the comment docs.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan
Copy link
Contributor

ubogdan commented Mar 30, 2022

@jilleJr Thanks for your contribution.

@ubogdan ubogdan merged commit 957b087 into swaggo:master Mar 30, 2022
ubogdan added a commit that referenced this pull request Mar 30, 2022
@applejag applejag deleted the feature/go-1.18 branch March 30, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to go 1.18 for generics parsing support
3 participants