Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensions in parameters should be part of the description column instead of the name column #9883

Merged
merged 3 commits into from
May 7, 2024
Merged

Extensions in parameters should be part of the description column instead of the name column #9883

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9eaf126
Move parameter extension fields from parameters-col_name to parameter…
jrossignol Apr 26, 2024
bf1a801
Merge branch 'master' into master
glowcloud May 7, 2024
aa4a901
Merge branch 'master' into master
glowcloud May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/core/components/parameter-row.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,8 +284,6 @@ export default class ParameterRow extends Component {
{ isOAS3 && param.get("deprecated") ? "deprecated": null }
</div>
<div className="parameter__in">({ param.get("in") })</div>
{ !showCommonExtensions || !commonExt.size ? null : commonExt.entrySeq().map(([key, v]) => <ParameterExt key={`${key}-${v}`} xKey={key} xVal={v} /> )}
{ !showExtensions || !extensions.size ? null : extensions.entrySeq().map(([key, v]) => <ParameterExt key={`${key}-${v}`} xKey={key} xVal={v} /> )}
</td>

<td className="parameters-col_description">
Expand Down Expand Up @@ -374,6 +372,9 @@ export default class ParameterRow extends Component {
) : null
}

{ !showCommonExtensions || !commonExt.size ? null : commonExt.entrySeq().map(([key, v]) => <ParameterExt key={`${key}-${v}`} xKey={key} xVal={v} /> )}
{ !showExtensions || !extensions.size ? null : extensions.entrySeq().map(([key, v]) => <ParameterExt key={`${key}-${v}`} xKey={key} xVal={v} /> )}

</td>

</tr>
Expand Down