-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: consolidate syntax highlighting code into standalone plugin #9783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing any issues in the code, the only thing I was wondering about was the removal of getConfigs
from here
: <Curl request={ curlRequest } getConfigs={ getConfigs } />) } |
but I ran the code myself and it looks like we get it there anyway.
Also taking a look at the failing tests, not seeing the issues yet except for having to update the import path in test/unit/components/highlight-code
and then to mock getting components for SyntaxHighlighter there.
If you access a component with |
This has been addressed by additional commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
All the syntax highlighting code has been consolidated into single overridable plugin.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests