Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show minimum and maximum in parameter query #5674

Closed
wants to merge 1 commit into from

Conversation

koooge
Copy link

@koooge koooge commented Oct 30, 2019

Description

Hi there. query parameter does not show minimum/maximum value, but it makes the doc ambiguous. So I would like swagger-ui to show minimum and maximum value

Motivation and Context

refs #5016

How Has This Been Tested?

Screenshots (if appropriate):

Screen Shot 2019-10-30 at 14 50 58

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@hkosova
Copy link
Contributor

hkosova commented Mar 5, 2020

Alternative PR that reuses the existing showCommonExtensions functionality: #5901

@tim-lai
Copy link
Contributor

tim-lai commented Jun 10, 2020

@koooge Thanks for the PR contribution! This functionality has been implemented in an alternative PR mentioned in the comments above.

@tim-lai tim-lai closed this Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants