Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No request url or response body data on file upload #413

Merged
merged 1 commit into from
Mar 6, 2014

Conversation

spil-johan
Copy link
Contributor

When the operations contains a file input the response data is wrapped as a shred response. The showStatus method does not take care of this and will not show the data in the UI. This is a simple hack to fix this.

@pySilver
Copy link

pySilver commented Mar 5, 2014

+1 please merge this.

fehguy added a commit that referenced this pull request Mar 6, 2014
No request url or response body data on file upload
@fehguy fehguy merged commit 77aa535 into swagger-api:master Mar 6, 2014
pySilver added a commit to pySilver/django-rest-swagger that referenced this pull request Mar 6, 2014
@pySilver
Copy link

pySilver commented Mar 6, 2014

Small issue with response headers:
http://monosnap.com/image/uRYLZ3rPLwspHOFw4sZHjQskU3xZwv

@fehguy
Copy link
Contributor

fehguy commented Mar 6, 2014

Is this using IE?

@pySilver
Copy link

pySilver commented Mar 7, 2014

Nop, latest chrome. This formatting issue happens in file uploads only - any other rest endpoind renders fine.

Dnia 6 mar 2014 o godz. 16:14 Tony Tam [email protected] napisał(a):

Is this using IE?


Reply to this email directly or view it on GitHub.

@spil-johan
Copy link
Contributor Author

Would this fix the issue for you as well? #418

@pySilver
Copy link

@spil-johan no, not really still has some issue http://monosnap.com/image/QFmXGVwc8wux4xCfe51VDJc6dpidiU

This problem appears only for file uploads, rest of api endpoints are fine: http://monosnap.com/image/GYwaCL4K7inIRun10hZkwJRdVCGOYO

@fehguy
Copy link
Contributor

fehguy commented Mar 19, 2014

Hi, I just can't reproduce this using swagger-ui in master and swagger-js version 2.0.23. Can you please verify the swagger-js version? The shred stuff all comes from there, and it's been pretty thoroughly tested.

vincent-zurczak pushed a commit to roboconf/swagger-ui that referenced this pull request Aug 18, 2016
No request url or response body data on file upload
napster0125 pushed a commit to napster0125/django-swagger-with-restapi that referenced this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants