Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use isomorphic solution for base64 encoding #2526

Merged
merged 4 commits into from
May 6, 2022

Conversation

char0n
Copy link
Member

@char0n char0n commented May 6, 2022

btoa npm dependency was using Buffer without an import.
This causes probles in bundler environemnt and Node.js
polyfills needs to be applied.

Refs swagger-api/swagger-editor#3042

How Has This Been Tested?

Types of changes

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

btoa npm dependency was using Buffer without an import.
This causes probles in bundler environemnt and Node.js
polyfills needs to be applied.

Refs swagger-api/swagger-editor#3042
@char0n char0n force-pushed the char0n/get-rid-of-btoa branch from 65f49c8 to 3165468 Compare May 6, 2022 09:34
@char0n char0n self-assigned this May 6, 2022
@char0n char0n added type: enhancement dependencies Pull requests that update a dependency file labels May 6, 2022
@char0n char0n merged commit 4832f32 into master May 6, 2022
swagger-bot pushed a commit that referenced this pull request May 6, 2022
## [3.18.5](v3.18.4...v3.18.5) (2022-05-06)

### Bug Fixes

* use isomorphic solution for base64 encoding ([#2526](#2526)) ([4832f32](4832f32))
@swagger-bot
Copy link
Contributor

🎉 This PR is included in version 3.18.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@char0n char0n deleted the char0n/get-rid-of-btoa branch January 31, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file released type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants