clean code

src/execute/index.js

@@ -1,4 +1,4 @@
-import getIn from 'lodash/get';
+import get from 'lodash/get';
 import isPlainObject from 'lodash/isPlainObject';
 import url from 'url';
 import cookie from 'cookie';
@@ -21,22 +21,23 @@ const OperationNotFoundError = createError(
   }
 );
 
-const findParametersWithName = (name, parameters) => parameters.filter((p) => p.name === name);
+const findParametersWithName = (name, parameters) =>
+  parameters.filter((parameter) => parameter.name === name);
 
 // removes parameters that have duplicate 'in' and 'name' properties
 const deduplicateParameters = (parameters) => {
   const paramsMap = {};
-  parameters.forEach((p) => {
-    if (!paramsMap[p.in]) {
-      paramsMap[p.in] = {};
+  parameters.forEach((parameter) => {
+    if (!paramsMap[parameter.in]) {
+      paramsMap[parameter.in] = {};
     }
-    paramsMap[p.in][p.name] = p;
+    paramsMap[parameter.in][parameter.name] = parameter;
   });
 
   const dedupedParameters = [];
-  Object.keys(paramsMap).forEach((i) => {
-    Object.keys(paramsMap[i]).forEach((p) => {
-      dedupedParameters.push(paramsMap[i][p]);
+  Object.keys(paramsMap).forEach((param) => {
+    Object.keys(paramsMap[param]).forEach((parameter) => {
+      dedupedParameters.push(paramsMap[param][parameter]);
     });
   });
   return dedupedParameters;
@@ -285,9 +286,9 @@ export function baseUrl(obj) {
 
 function oas3BaseUrl({ spec, pathName, method, server, contextUrl, serverVariables = {} }) {
   const servers =
-    getIn(spec, ['paths', pathName, (method || '').toLowerCase(), 'servers']) ||
-    getIn(spec, ['paths', pathName, 'servers']) ||
-    getIn(spec, ['servers']);
+    get(spec, ['paths', pathName, (method || '').toLowerCase(), 'servers']) ||
+    get(spec, ['paths', pathName, 'servers']) ||
+    get(spec, ['servers']);
 
   let selectedServerUrl = '';
   let selectedServerObj = null;

src/execute/oas3/style-serializer.js

@@ -1,3 +1,5 @@
+import { Buffer } from 'buffer';
+
 const isRfc3986Reserved = (char) => ":/?#[]@!$&'()*+,;=".indexOf(char) > -1;
 const isRrc3986Unreserved = (char) => /^[a-z0-9\-._~]+$/i.test(char);
 

src/execute/swagger2/build-request.js

@@ -29,20 +29,22 @@ export default function buildRequest(options, req) {
       [req.headers['Content-Type']] = spec.consumes;
     } else if (
       operation.parameters &&
-      operation.parameters.filter((p) => p.type === 'file').length
+      operation.parameters.filter((parameter) => parameter.type === 'file').length
     ) {
       req.headers['Content-Type'] = 'multipart/form-data';
     } else if (
       operation.parameters &&
-      operation.parameters.filter((p) => p.in === 'formData').length
+      operation.parameters.filter((parameter) => parameter.in === 'formData').length
     ) {
       req.headers['Content-Type'] = 'application/x-www-form-urlencoded';
     }
   } else if (requestContentType) {
     const isBodyParamPresent =
-      operation.parameters && operation.parameters.filter((p) => p.in === 'body').length > 0;
+      operation.parameters &&
+      operation.parameters.filter((parameter) => parameter.in === 'body').length > 0;
     const isFormDataParamPresent =
-      operation.parameters && operation.parameters.filter((p) => p.in === 'formData').length > 0;
+      operation.parameters &&
+      operation.parameters.filter((parameter) => parameter.in === 'formData').length > 0;
     if (isBodyParamPresent || isFormDataParamPresent) {
       req.headers['Content-Type'] = requestContentType;
     }

src/helpers.js

@@ -160,10 +160,10 @@ export function normalizeSwagger(parsedSpec) {
 
         const opList = map[oid];
         if (opList.length > 1) {
-          opList.forEach((o, i) => {
+          opList.forEach((op, key) => {
             // eslint-disable-next-line no-underscore-dangle
-            o.__originalOperationId = o.__originalOperationId || o.operationId;
-            o.operationId = `${oid}${i + 1}`;
+            op.__originalOperationId = op.__originalOperationId || op.operationId;
+            op.operationId = `${oid}${key + 1}`;
           });
         } else if (typeof operation.operationId !== 'undefined') {
           // Ensure we always add the normalized operation ID if one already exists

src/http/index.js

@@ -202,7 +202,7 @@ function formatKeyValue(key, input, skipEncoding = false) {
   const { collectionFormat, allowEmptyValue, serializationOption, encoding } = input;
   // `input` can be string
   const value = typeof input === 'object' && !Array.isArray(input) ? input.value : input;
-  const encodeFn = skipEncoding ? (k) => k.toString() : (k) => encodeURIComponent(k);
+  const encodeFn = (k) => (skipEncoding ? k.toString() : encodeURIComponent(k));
   const encodedKey = encodeFn(key);
 
   if (typeof value === 'undefined' && allowEmptyValue) {
@@ -290,8 +290,10 @@ function formatKeyValueBySerializationOption(key, value, skipEncoding, serializa
     : serializationOption && serializationOption.allowReserved
     ? 'unsafe'
     : 'reserved';
-  const encodeFn = (v) => encodeDisallowedCharacters(v, { escape });
-  const encodeKeyFn = skipEncoding ? (k) => k : (k) => encodeDisallowedCharacters(k, { escape });
+  const encodeFn = (str) => encodeDisallowedCharacters(str, { escape });
+  const encodeKeyFn = skipEncoding
+    ? (str) => str
+    : (str) => encodeDisallowedCharacters(str, { escape });
 
   // Primitive
   if (typeof value !== 'object') {
@@ -432,8 +434,8 @@ export function mergeInQueryOrForm(req = {}) {
 
 // Wrap a http function ( there are otherways to do this, consider this deprecated )
 export function makeHttp(httpFn, preFetch, postFetch) {
-  postFetch = postFetch || ((a) => a);
-  preFetch = preFetch || ((a) => a);
+  postFetch = postFetch || ((req) => req);
+  preFetch = preFetch || ((req) => req);
   return (req) => {
     if (typeof req === 'string') {
       req = { url: req };

src/specmap/index.js

@@ -97,7 +97,7 @@ class SpecMap {
           return true;
         }
 
-        return path.every((val, i) => val === tested[i]);
+        return path.every((val, key) => val === tested[key]);
       };
 
       return function* generator(patches, specmap) {
@@ -342,7 +342,7 @@ class SpecMap {
 
     // A different plugin runs, wait for all promises to resolve, then retry
     if (plugin !== this.currentPlugin && this.promisedPatches.length) {
-      const promises = this.promisedPatches.map((p) => p.value);
+      const promises = this.promisedPatches.map((parameter) => parameter.value);
 
       // Waits for all to settle instead of Promise.all which stops on rejection
       return Promise.all(promises.map((promise) => promise.then(noop, noop))).then(() =>

src/specmap/lib/all-of.js

@@ -46,7 +46,7 @@ export default {
     // remove existing content
     patches.push(specmap.replace(parent, {}));
 
-    val.forEach((toMerge, i) => {
+    val.forEach((toMerge, position) => {
       if (!specmap.isObject(toMerge)) {
         if (alreadyAddError) {
           return null;
@@ -68,7 +68,7 @@ export default {
 
       const absoluteRefPatches = generateAbsoluteRefPatches(toMerge, collapsedFullPath, {
         getBaseUrlForNodePath: (nodePath) =>
-          specmap.getContext([...fullPath, i, ...nodePath]).baseDoc,
+          specmap.getContext([...fullPath, position, ...nodePath]).baseDoc,
         specmap,
       });
 

src/specmap/lib/context-tree.js

@@ -31,8 +31,8 @@ export default class ContextTree {
     let branch = this.root;
     let child;
     let token;
-    for (let i = 0; i < path.length; i += 1) {
-      token = path[i];
+    for (let position = 0; position < path.length; position += 1) {
+      token = path[position];
       child = branch.children;
       if (!child[token]) {
         break;

src/specmap/lib/parameters.js

@@ -8,9 +8,9 @@ export default {
       const opPath = fullPath.slice(0, -1);
       const op = { ...lib.getIn(specmap.spec, opPath) };
 
-      parameters.forEach((param, i) => {
+      parameters.forEach((param, position) => {
         try {
-          val[i].default = specmap.parameterMacro(op, param);
+          val[position].default = specmap.parameterMacro(op, param);
         } catch (e) {
           const err = new Error(e);
           err.fullPath = fullPath;

src/specmap/lib/properties.js

@@ -6,9 +6,9 @@ export default {
     const val = { ...properties };
 
     // eslint-disable-next-line no-restricted-syntax, guard-for-in
-    for (const k in properties) {
+    for (const position in properties) {
       try {
-        val[k].default = specmap.modelPropertyMacro(val[k]);
+        val[position].default = specmap.modelPropertyMacro(val[position]);
       } catch (e) {
         const err = new Error(e);
         err.fullPath = fullPath; // This is an array

src/specmap/lib/refs.js

@@ -323,8 +323,8 @@ function extractFromDoc(docPath, pointer) {
     // `spec` and `docCache[basePath]` refer to the exact same object).
     // See test "should resolve a cyclic spec when baseDoc is specified".
     try {
-      const v = extract(pointer, doc);
-      return Object.assign(Promise.resolve(v), { __value: v });
+      const val = extract(pointer, doc);
+      return Object.assign(Promise.resolve(val), { __value: val });
     } catch (e) {
       return Promise.reject(e);
     }
@@ -544,9 +544,9 @@ function pointerAlreadyInPath(pointer, basePath, parent, specmap) {
  */
 function patchValueAlreadyInPath(root, patch) {
   const ancestors = [root];
-  patch.path.reduce((parent, p) => {
-    ancestors.push(parent[p]);
-    return parent[p];
+  patch.path.reduce((parent, currentValue) => {
+    ancestors.push(parent[currentValue]);
+    return parent[currentValue];
   }, root);
   return pointToAncestor(patch.value);