Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: escaping inconsistent to requestInterceptor #1252

Closed
wants to merge 1 commit into from
Closed

Failing test: escaping inconsistent to requestInterceptor #1252

wants to merge 1 commit into from

Conversation

srl295
Copy link
Contributor

@srl295 srl295 commented Feb 27, 2018

For: #1220

npm t gives:

Error: Expected 'percent-twentyseven' to equal 'quote'

  • Request has a quote (') in it
  • The interceptor sees req.url ending in quote (') which is a perfectly valid thing for a URL to end in…
  • However, the xmock shows the actual URL ends in /%27

Description

Utterly fails. (see issue above, PR not ready to merge)

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@srl295 srl295 force-pushed the interceptor-url-test branch from 974ba2a to c4fac2d Compare February 27, 2018 16:16
@webron webron requested a review from shockey February 27, 2018 16:19
@shockey
Copy link
Contributor

shockey commented Mar 3, 2018

Thanks for the failing tests - I'll do my best to find some time to figure out what's going on.

@srl295
Copy link
Contributor Author

srl295 commented Mar 7, 2018

It's Fetch that escapes

@char0n
Copy link
Member

char0n commented May 1, 2020

@srl295 would be able to rebase this PR on top of current swagger-js? Thank you!

@char0n char0n mentioned this pull request May 1, 2020
Closed
@srl295
Copy link
Contributor Author

srl295 commented May 4, 2020

@char0n I'll try!

@srl295
Failing test: escaping inconsistent to requestInterceptor
5e17a17 
For: swagger-api#1220

`npm t` gives:
>  Error: Expected 'percent-twentyseven' to equal 'quote'

* Request has a quote (') in it
* The interceptor sees req.url ending in quote (') which is a perfectly valid thing for a URL to end in…
* However, the xmock  shows the actual URL ends in /%27
@srl295 srl295 force-pushed the interceptor-url-test branch from c4fac2d to 5e17a17 Compare May 4, 2020 15:18
@srl295
Copy link
Contributor Author

srl295 commented May 4, 2020

@char0n done! 5e17a17

@char0n char0n requested review from char0n and removed request for shockey May 4, 2020 15:22
@char0n
Copy link
Member

char0n commented May 4, 2020

The moment we switch to [email protected], these tests should pass, and I'll incorporate them into codebase. @srl295 thanks again!

@srl295
Copy link
Contributor Author

srl295 commented May 4, 2020

The moment we switch to [email protected], these tests should pass, and I'll incorporate them into codebase. @srl295 thanks again!

Welcome, thank you for swagger!

@char0n char0n self-assigned this May 14, 2020
@frantuma frantuma added this to the M5 milestone Jul 8, 2020
@frantuma frantuma modified the milestones: M5, M7 Aug 14, 2020
@frantuma frantuma modified the milestones: M7, M9 Sep 30, 2020
@frantuma frantuma modified the milestones: M9, M10 Oct 21, 2020
@char0n char0n removed their assignment Dec 14, 2021
@char0n char0n removed their request for review December 14, 2021 09:17
char0n added a commit that referenced this pull request Sep 12, 2023
@char0n
test: add quote test
f9207bd 
Refs #1252
@char0n
Copy link
Member

char0n commented Sep 12, 2023

@srl295 took five years, but you test have been finally integrated in f9207bd ;]

Thank you!

@char0n char0n closed this Sep 12, 2023
@char0n char0n self-assigned this Sep 12, 2023
@srl295 srl295 deleted the interceptor-url-test branch September 14, 2023 05:31
@srl295
Copy link
Contributor Author

srl295 commented Sep 14, 2023

@srl295 took five years, but you test have been finally integrated in f9207bd ;]

Thank you!

Welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@char0n char0n

Labels
cat: testing version: 3.x
Projects
None yet
Milestone
M10
Development

Successfully merging this pull request may close these issues.
4 participants
@srl295 @shockey @char0n @frantuma