Bug/1332 standalone menus #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1332.
To make a long story short... we use
react-dd-menufor the Topbar menus, and it leans on CSSTransitionGroup for animations. Historically that's been available as an addon in React's core, but those addons are being moved out of the core and into their own packages. However, as React's developers have noted, these addon packages need their own copy of React.This worked while all Editor components were under one bundle, but broke when we split off the Standalone preset. The implementation of these React addons resulted in a situation in which everything except the addons were respecting the Webpack configuration to get their React from
window.React.See facebook/react#7874 for another instance of this problem.
Fixed this by pulling in the one component we were using from
react-dd-menu, and swapping out thereact-addons-css-transition-grouppackage for the less finickyreact-transition-group/CSSTransitionGroupdrop-in replacement.