JAX-RS: make Reader more easy to extend #4431
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to make a parser to generate openapi specification file for fluent-http. It is a bit different from JAX-RS but we can reuse annotations (@parameter, @operation, ....).
We've seen that some methods, class attributes of Reader are protected that may indicate that the class is extensible.
Unfortunately there are some inconsistencies : for example the private components property is used in utility methods that are private. So even if the field is duplicated in a daughter class, it won't be populated.
This pull request is trying to fix this.
This PR does the following in the JAW-RS Reader class :
components
,paths
,openApiTags
to be able to share instance with children classessetOperationObjectFromApiOperationAnnotation
to be able to call it from children classesTell us if you have suggestions to do differently (because we'd have misused the intended API) or examples for other framework adaptations.
Thank you