Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Cleanup ThreadPool with atexit rather than __del__ #10002

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ from __future__ import absolute_import

import datetime
import json
import atexit
import mimetypes
from multiprocessing.pool import ThreadPool
import os
Expand Down Expand Up @@ -70,14 +71,16 @@ class ApiClient(object):
# Set default User-Agent.
self.user_agent = '{{#httpUserAgent}}{{{.}}}{{/httpUserAgent}}{{^httpUserAgent}}Swagger-Codegen/{{{packageVersion}}}/python{{/httpUserAgent}}'

def __del__(self):
def close(self):
if self._pool is not None:
self._pool.close()
self._pool.join()
self._pool = None

@property
def pool(self):
if self._pool is None:
atexit.register(self.close)
self._pool = ThreadPool()
return self._pool

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ class Configuration(object):

if self.refresh_api_key_hook:
self.refresh_api_key_hook(self)

key = self.api_key.get(identifier)
if key:
prefix = self.api_key_prefix.get(identifier)
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2.4.9-SNAPSHOT
2.4.13-SNAPSHOT
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

import datetime
import json
import atexit
import mimetypes
from multiprocessing.pool import ThreadPool
import os
Expand Down Expand Up @@ -76,14 +77,16 @@ def __init__(self, configuration=None, header_name=None, header_value=None,
# Set default User-Agent.
self.user_agent = 'Swagger-Codegen/1.0.0/python'

def __del__(self):
def close(self):
if self._pool is not None:
self._pool.close()
self._pool.join()
self._pool = None

@property
def pool(self):
if self._pool is None:
atexit.register(self.close)
self._pool = ThreadPool()
return self._pool

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ def __init__(self):
self.api_key = {}
# dict to store API prefix (e.g. Bearer)
self.api_key_prefix = {}
# function to refresh API key if expired
self.refresh_api_key_hook = None
# Username for HTTP basic authentication
self.username = ""
# Password for HTTP basic authentication
Expand Down Expand Up @@ -203,11 +205,17 @@ def get_api_key_with_prefix(self, identifier):
:param identifier: The identifier of apiKey.
:return: The token for api key authentication.
"""
if (self.api_key.get(identifier) and
self.api_key_prefix.get(identifier)):
return self.api_key_prefix[identifier] + ' ' + self.api_key[identifier] # noqa: E501
elif self.api_key.get(identifier):
return self.api_key[identifier]

if self.refresh_api_key_hook:
self.refresh_api_key_hook(self)

key = self.api_key.get(identifier)
if key:
prefix = self.api_key_prefix.get(identifier)
if prefix:
return "%s %s" % (prefix, key)
else:
return key

def get_basic_auth_token(self):
"""Gets HTTP basic authentication header (string).
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/python/.swagger-codegen/VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2.4.9-SNAPSHOT
2.4.13-SNAPSHOT
5 changes: 4 additions & 1 deletion samples/client/petstore/python/petstore_api/api_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

import datetime
import json
import atexit
import mimetypes
from multiprocessing.pool import ThreadPool
import os
Expand Down Expand Up @@ -76,14 +77,16 @@ def __init__(self, configuration=None, header_name=None, header_value=None,
# Set default User-Agent.
self.user_agent = 'Swagger-Codegen/1.0.0/python'

def __del__(self):
def close(self):
if self._pool is not None:
self._pool.close()
self._pool.join()
self._pool = None

@property
def pool(self):
if self._pool is None:
atexit.register(self.close)
self._pool = ThreadPool()
return self._pool

Expand Down