Fix some more issues

[JobDoesburg]

Closes #132, fixes the order fetch timeout (that wasn't working apparently) and prevents 404's from occurring because under certain timings, an order could still be PUT after it was DELETEd by Thadmin

[github-actions]

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Plan 📖success

Show Plan

terraform
module.thadmin_routing.module.cloudfront.aws_cloudfront_origin_access_identity.this["s3_bucket"]: Refreshing state... [id=E3JOC36ODMBL65]
module.thadmin_hosting.aws_s3_bucket.this: Refreshing state... [id=thalia-thadmin-staging]
module.thadmin_routing.module.acm.aws_acm_certificate.this: Refreshing state... [id=arn:aws:acm:us-east-1:627002765486:certificate/565d3a00-d047-48f2-956a-aed08dd6956b]
module.thadmin_routing.module.acm.aws_route53_record.validation["thadmin-staging.technicie.nl"]: Refreshing state... [id=Z3I4ZHBBD5NSHU__f4c1968cf0da5157d0f46ed63ecf426e.thadmin-staging.technicie.nl._CNAME]
module.thadmin_routing.module.acm.aws_acm_certificate_validation.this: Refreshing state... [id=2021-04-14 20:17:10 +0000 UTC]
module.thadmin_routing.module.cloudfront.aws_cloudfront_distribution.this[0]: Refreshing state... [id=E2ZP8HCBLISQFN]
module.thadmin_routing.aws_s3_bucket_policy.bucket_policy: Refreshing state... [id=thalia-thadmin-staging]
module.thadmin_routing.aws_route53_record.api: Refreshing state... [id=Z3I4ZHBBD5NSHU_thadmin-staging_A]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["mstile-310x310.png"]: Refreshing state... [id=mstile-310x310.png]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["img/anonymousUser.61cf6ed7.jpg"]: Refreshing state... [id=img/anonymousUser.61cf6ed7.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-1125-2436.jpg"]: Refreshing state... [id=apple-splash-1125-2436.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-1668-2388.jpg"]: Refreshing state... [id=apple-splash-1668-2388.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["site.webmanifest"]: Refreshing state... [id=site.webmanifest]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["js/chunk-3f8868f0.48ae0bea.js"]: Refreshing state... [id=js/chunk-3f8868f0.48ae0bea.js]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["mstile-150x150.png"]: Refreshing state... [id=mstile-150x150.png]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["favicon.svg"]: Refreshing state... [id=favicon.svg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-2208-1242.jpg"]: Refreshing state... [id=apple-splash-2208-1242.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-2160-1620.jpg"]: Refreshing state... [id=apple-splash-2160-1620.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-1334-750.jpg"]: Refreshing state... [id=apple-splash-1334-750.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-640-1136.jpg"]: Refreshing state... [id=apple-splash-640-1136.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-2048-1536.jpg"]: Refreshing state... [id=apple-splash-2048-1536.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["js/chunk-vendors.8985e044.js.map"]: Refreshing state... [id=js/chunk-vendors.8985e044.js.map]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-1136-640.jpg"]: Refreshing state... [id=apple-splash-1136-640.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-2532-1170.jpg"]: Refreshing state... [id=apple-splash-2532-1170.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["android-chrome-512x512.png"]: Refreshing state... [id=android-chrome-512x512.png]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-1242-2688.jpg"]: Refreshing state... [id=apple-splash-1242-2688.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["favicon-16x16.png"]: Refreshing state... [id=favicon-16x16.png]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["browserconfig.xml"]: Refreshing state... [id=browserconfig.xml]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-2224-1668.jpg"]: Refreshing state... [id=apple-splash-2224-1668.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-2778-1284.jpg"]: Refreshing state... [id=apple-splash-2778-1284.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-1170-2532.jpg"]: Refreshing state... [id=apple-splash-1170-2532.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["js/chunk-vendors.8985e044.js"]: Refreshing state... [id=js/chunk-vendors.8985e044.js]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["safari-pinned-tab.svg"]: Refreshing state... [id=safari-pinned-tab.svg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["js/app.6be75c99.js"]: Refreshing state... [id=js/app.6be75c99.js]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-1284-2778.jpg"]: Refreshing state... [id=apple-splash-1284-2778.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["favicon-32x32.png"]: Refreshing state... [id=favicon-32x32.png]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["favicon.ico"]: Refreshing state... [id=favicon.ico]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-2048-2732.jpg"]: Refreshing state... [id=apple-splash-2048-2732.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-2436-1125.jpg"]: Refreshing state... [id=apple-splash-2436-1125.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["mstile-70x70.png"]: Refreshing state... [id=mstile-70x70.png]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-2732-2048.jpg"]: Refreshing state... [id=apple-splash-2732-2048.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["css/app.75fc30cc.css"]: Refreshing state... [id=css/app.75fc30cc.css]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["js/chunk-3f8868f0.48ae0bea.js.map"]: Refreshing state... [id=js/chunk-3f8868f0.48ae0bea.js.map]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-828-1792.jpg"]: Refreshing state... [id=apple-splash-828-1792.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["index.html"]: Refreshing state... [id=index.html]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-2688-1242.jpg"]: Refreshing state... [id=apple-splash-2688-1242.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["css/chunk-vendors.52eaf30c.css"]: Refreshing state... [id=css/chunk-vendors.52eaf30c.css]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-1242-2208.jpg"]: Refreshing state... [id=apple-splash-1242-2208.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["mstile-310x150.png"]: Refreshing state... [id=mstile-310x150.png]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-1620-2160.jpg"]: Refreshing state... [id=apple-splash-1620-2160.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["mstile-144x144.png"]: Refreshing state... [id=mstile-144x144.png]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["js/app.6be75c99.js.map"]: Refreshing state... [id=js/app.6be75c99.js.map]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["img/backgroundImage.5f59aad8.jpg"]: Refreshing state... [id=img/backgroundImage.5f59aad8.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-2388-1668.jpg"]: Refreshing state... [id=apple-splash-2388-1668.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["favicon.png"]: Refreshing state... [id=favicon.png]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["android-chrome-192x192.png"]: Refreshing state... [id=android-chrome-192x192.png]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-1792-828.jpg"]: Refreshing state... [id=apple-splash-1792-828.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-750-1334.jpg"]: Refreshing state... [id=apple-splash-750-1334.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-touch-icon.png"]: Refreshing state... [id=apple-touch-icon.png]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-1536-2048.jpg"]: Refreshing state... [id=apple-splash-1536-2048.jpg]
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["apple-splash-1668-2224.jpg"]: Refreshing state... [id=apple-splash-1668-2224.jpg]
An execution plan has been generated and is shown below.

Resource actions are indicated with the following symbols:

create

~ update in-place


destroy

Terraform will perform the following actions:
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["index.html"] will be updated in-place
~ resource "aws_s3_bucket_object" "code_build_object" {

~ etag               = "c6d08f0172ea538798390fbe2881f6bc" -> "99b38752427471522ca8dfec8c7116d2"

id                 = "index.html"

tags               = {}

+ version_id         = (known after apply)

# (10 unchanged attributes hidden)

}
module.thadmin_hosting.aws_s3_bucket_object.code_build_object["js/app.6be75c99.js"] will be destroyed

resource "aws_s3_bucket_object" "code_build_object" {

acl                = "private" -> null
bucket             = "thalia-thadmin-staging" -> null
bucket_key_enabled = false -> null
content_type       = "text/javascript" -> null
etag               = "69e944cfebdc606632a4b7eaaeb6b622" -> null
force_destroy      = false -> null
id                 = "js/app.6be75c99.js" -> null
key                = "js/app.6be75c99.js" -> null
metadata           = {} -> null
source             = "/home/runner/work/thadmin/thadmin/infra/modules/hosting/../../..//dist/js/app.6be75c99.js" -> null
storage_class      = "STANDARD" -> null
tags               = {} -> null
tags_all           = {} -> null

}



module.thadmin_hosting.aws_s3_bucket_object.code_build_object["js/app.6be75c99.js.map"] will be destroyed

resource "aws_s3_bucket_object" "code_build_object" {

acl                = "private" -> null
bucket             = "thalia-thadmin-staging" -> null
bucket_key_enabled = false -> null
content_type       = "application/octet-stream" -> null
etag               = "d4899191439c293372b60df955115e15" -> null
force_destroy      = false -> null
id                 = "js/app.6be75c99.js.map" -> null
key                = "js/app.6be75c99.js.map" -> null
metadata           = {} -> null
source             = "/home/runner/work/thadmin/thadmin/infra/modules/hosting/../../..//dist/js/app.6be75c99.js.map" -> null
storage_class      = "STANDARD" -> null
tags               = {} -> null
tags_all           = {} -> null

}



module.thadmin_hosting.aws_s3_bucket_object.code_build_object["js/app.88e81c7d.js"] will be created

resource "aws_s3_bucket_object" "code_build_object" {

acl                    = "private"
bucket                 = "thalia-thadmin-staging"
bucket_key_enabled     = (known after apply)
content_type           = "text/javascript"
etag                   = "83d1879555dc13adf626c0583706f1c9"
force_destroy          = false
id                     = (known after apply)
key                    = "js/app.88e81c7d.js"
kms_key_id             = (known after apply)
server_side_encryption = (known after apply)
source                 = "/home/runner/work/thadmin/thadmin/infra/modules/hosting/../../..//dist/js/app.88e81c7d.js"
storage_class          = (known after apply)
tags_all               = (known after apply)
version_id             = (known after apply)

}



module.thadmin_hosting.aws_s3_bucket_object.code_build_object["js/app.88e81c7d.js.map"] will be created

resource "aws_s3_bucket_object" "code_build_object" {

acl                    = "private"
bucket                 = "thalia-thadmin-staging"
bucket_key_enabled     = (known after apply)
content_type           = "application/octet-stream"
etag                   = "2f34f73f07f7d65fabc1be134704a4b5"
force_destroy          = false
id                     = (known after apply)
key                    = "js/app.88e81c7d.js.map"
kms_key_id             = (known after apply)
server_side_encryption = (known after apply)
source                 = "/home/runner/work/thadmin/thadmin/infra/modules/hosting/../../..//dist/js/app.88e81c7d.js.map"
storage_class          = (known after apply)
tags_all               = (known after apply)
version_id             = (known after apply)

}



Plan: 2 to add, 1 to change, 2 to destroy.

Note: You didn't specify an "-out" parameter to save this plan, so Terraform

can't guarantee that exactly these actions will be performed if

"terraform apply" is subsequently run.

[JobDoesburg]

deploy