[PLOT_VIEW] Fix several minor issues #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
svlad-90
commented
Nov 26, 2024
•
svlad-90
commented
- The Gantt chart event ID is int32, but in the production use case, we need int64 to use a thread ID as a plot's event ID. Switch to the int64_t type.
- Fix a bug related to combining graph names from multiple string parts.
svlad-90
force-pushed
the
dev/vladyslav-goncharuk/ISSUE-223
branch
from
af558aa
to
ef16dd6
Compare
- The Gantt chart event ID is int32, but in the production use case, we need int64 to use a thread ID as a plot's event ID. Switch to the int64_t type. - Fix a bug related to combining graph names from multiple string parts. Signed-off-by: Vladyslav Goncharuk <[email protected]>
svlad-90
force-pushed
the
dev/vladyslav-goncharuk/ISSUE-223
branch
from
ef16dd6
to
1283104
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.