Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the openapi-codegen to our docker image #1772

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

svix-mman
Copy link
Contributor

@svix-mman svix-mman commented Feb 28, 2025

Using the docker image from svix/openapi-codegen#82
This results in the identical code.

I replaced the regen_openapi.sh with a multi-threaded python script

@svix-mman svix-mman requested a review from a team as a code owner February 28, 2025 23:49
@svix-mman
Copy link
Contributor Author

svix-mman commented Feb 28, 2025

CI is broken because it's trying to pull an image we have not yet published
CI is slow because I added a docker build command that take 10-15 minutes
Once I merge svix/openapi-codegen#82 this will simply be a docker pull

@svix-mman svix-mman force-pushed the mendy/use-docker-openapi-codegen branch 5 times, most recently from 4c5add5 to 1c57bb6 Compare March 1, 2025 22:47
@svix-jplatte
Copy link
Member

This PR is marked as ready for review but blocked on several other PRs + contains a replacement of the bash script with no explanation as to why (and doesn't delete the old script either). I'm guessing it is not in fact ready for review?

@svix-mman svix-mman marked this pull request as draft March 3, 2025 12:58
@svix-mman
Copy link
Contributor Author

This PR is marked as ready for review but blocked on several other PRs + contains a replacement of the bash script with no explanation as to why (and doesn't delete the old script either). I'm guessing it is not in fact ready for review?

yeah :)
let me mark it as draft

@svix-mman svix-mman force-pushed the mendy/use-docker-openapi-codegen branch 2 times, most recently from e6ff713 to 156b49f Compare March 3, 2025 18:35
@svix-mman svix-mman marked this pull request as ready for review March 3, 2025 18:35
@svix-mman svix-mman force-pushed the mendy/use-docker-openapi-codegen branch from 156b49f to 4106a30 Compare March 3, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants