-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rkhunter module #381
Add rkhunter module #381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! Just a few notes.
@@ -0,0 +1,239 @@ | |||
Checking for directory '/dev/ptyas' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it perhaps be smarter to have a list of directories and a list of files? These could then also be consumed by other genact modules later on. It's also fine if you want to just play these files from the top for now, your choice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have a look tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought about this and having files and directories in one file would be difficult to differentiate. If we decide to have normalized data for the Linux filesystem, I would create one file for directories and one for regular files. Maybe this could be done if another module needs this data?
src/modules/rkhunter.rs
Outdated
use crate::data::RKHUNTER_CHECKS_LIST; | ||
use crate::data::RKHUNTER_CHECKS_SHORT_LIST; | ||
use crate::data::RKHUNTER_INFOS_LIST; | ||
use crate::data::RKHUNTER_ROOTKITS_LIST; | ||
use crate::data::RKHUNTER_TASKS_LIST; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you merge these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reduced it to RKHUNTER_CHECKS_LIST, RKHUNTER_ROOTKITS_LIST and RKHUNTER_TASKS_LIST.
I could move the Rootkits into an array in the rkhunter module, but I am not sure if this is fine?
I like it! Merging as is. Thanks. :) |
It's me, again. 😄
This PR adds a module for rkhunter / Malware check: #45
Thing that could be improved before merge is to loop through multiple rootkit checks in one task (identifiable by "Performing ....").
Example output: