-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drag and drop SVG with 'Add imported graphic to 2D-view' enabled makes the load process loop. #360
Comments
Strange issue, but is fixed now: https://github.com/svenhb/GRBL-Plotter/blob/master/GRBL-Plotter_Setup_1_7_0_2_g.exe |
"but is fixed now:" "I also added multiple file import, if 'Add imported graphic to 2D-view' is enabled." If the Multiply option in 'Setup\Path import\Path addons' is enabled those multiplications are applied to each of the imported images. Note that the multiply option multiplies along both the X and Y axes, if those values are set and the option is selected. This is not quite what you describe, but is correct IMHO. "If this option is disabled, just the fist file will be imported." For my use case the 'Add imported graphic...' option will add date-printed information to each drawing. Each day I create a new date SVG, then I import it with any image printed that day. It saves having to edit each image with a new date. I imagine a similar usage would apply to logos, borders, headings, watermarks and anything similar which needs to be in the more than one image but might get updated from time to time. An arbitrary limit on the number of files selected at one time might be worthwhile to protect the user from gross selection errors. |
It was the first try, Perhaps I will add some options how to handle added files. |
Some improovment with multiple import: https://github.com/svenhb/GRBL-Plotter/releases |
Describe the bug
Drag and drop SVG with 'Add imported graphic to 2D-view' enabled makes the load process loop.
Windows 10, GRBL-Plotter Version 1.7.0.0.
To Reproduce
Expected behavior
The 'Select Use Case ' panel should load and the loading process should stop and wait for user input. Only one GCode listing should be created.
Note 1: As this happens with Drag and Drop, and multiple drop files are not supported, there would never be an existing graphic for the new graphic to be added to.
Note 2: I believe it would be acceptable for the 'Add imported graphic to 2D-view' option to be disabled at each shutdown. It would therefore need to be explicitly re-enabled, if required, after the first image had been loaded.
Note 3: If Drag and Drop is upgraded to support multiple drops then the behaviour for the case of multiple drops with the 'Add' option disabled would need to be defined. Suitable behaviour would be to treat multiple drops as if the 'Add' option had been enabled.
Screenshots
If applicable, add screenshots to help explain your problem.
The text was updated successfully, but these errors were encountered: