Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading ellipses stored in blocks can result in incorrect results #359

Closed
lianzaozi opened this issue Sep 9, 2023 · 8 comments
Closed

Comments

@lianzaozi
Copy link

The software version 1.7.0.2 reads elliptical arcs stored in blocks, which may result in incorrect orientation of the read graphics. This error should exist in all versions

test file
test.zip

test image
On the left is the result read by version 1.7.0.2 software, and on the right is the result read by CAD software
4

@lianzaozi lianzaozi added the bug label Sep 9, 2023
@svenhb
Copy link
Owner

svenhb commented Sep 9, 2023

If I draw such ellipse in LibreCAD, the import in GRBL-Plotter is correct.

@lianzaozi
Copy link
Author

lianzaozi commented Sep 9, 2023

I feel that the problem lies in the fact that the plotter software may have a problem parsing the code stored in the elliptical arc part of the block

I used autocad 2019 to draw this figure, and the elliptic arc is in a block. If the elliptic arc is not in the block, it is also correct for plotter to read the elliptic arc that is not in the block

The steps for drawing this elliptic arc

  1. Draw an elliptic arc in AutoCAD
  2. Save the elliptic arc drawn in the first step as a block named "123".
  3. Insert the block named "123" stored in step 2 and rotate it 30 degrees

I guess is that the plotter software may have a problem with the part of the code that interprets the elliptic arc stored in the block

svenhb added a commit that referenced this issue Sep 9, 2023
@svenhb
Copy link
Owner

svenhb commented Sep 9, 2023

Found the problem: I applied group-angle also to start/end angle of ellipse.
Try https://github.com/svenhb/GRBL-Plotter/blob/master/GRBL-Plotter_Setup_1_7_0_2_g.exe

@lianzaozi
Copy link
Author

lianzaozi commented Sep 11, 2023

I still need more testing for version 1.7.0.2-g software

There is also an error reading arcs stored in the block(Testing with version 1.7.0.2 software)

Plotter software and AutoCAD software read the arcs stored in the block, and the coordinates of the starting point of the arcs displayed by the two software are different

111

test file

dxf.zip

@svenhb
Copy link
Owner

svenhb commented Sep 11, 2023

@lianzaozi
Copy link
Author

After testing, version 1.7.0.2-g of the software temporarily found no issues when reading elliptical arcs and arcs stored in blocks

@svenhb
Copy link
Owner

svenhb commented Sep 12, 2023

👍 I hope you mean 1.7.0.2-h

@lianzaozi
Copy link
Author

Sorry, there was an error in the input of the previous reply version

Yes, the version I tested is 1.7.0.2-h, and no issues have been found so far

@svenhb svenhb closed this as completed Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants