Remove ExecName method from Exec interface again
#87
Milestone
Comments
svengreb
changed the title
Name method from Task interface againExecName method from Exec interface again
svengreb
added a commit
that referenced
this issue
Apr 24, 2021
In GH-79 [1] a new `ExecName() string` method has been added to the `Exec` interface [2] to improve the way how `RunnerExec` [3] handles the name of the executable file, but it turned out that this is not useful at all and also broke the separation of concern between the `Task` and `Runner` interfaces. Therefore the method has been removed again. [1]: #79 [2]: https://pkg.go.dev/github.com/svengreb/wand/pkg/task#Exec [3]: https://pkg.go.dev/github.com/svengreb/wand/pkg/task#RunnerExec GH-87
svengreb
added a commit
that referenced
this issue
Apr 24, 2021
In GH-79 [1] a new `ExecName() string` method has been added to the `Exec` interface [2] to improve the way how `RunnerExec` [3] handles the name of the executable file, but it turned out that this is not useful at all and also broke the separation of concern between the `Task` and `Runner` interfaces. Therefore the method has been removed again. [1]: #79 [2]: https://pkg.go.dev/github.com/svengreb/wand/pkg/task#Exec [3]: https://pkg.go.dev/github.com/svengreb/wand/pkg/task#RunnerExec Closes GH-87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #79 a new
ExecName() stringmethod has been added to theExecinterface to improve the way howRunnerExechandles the name of the executable file, but it turns out that this is not useful at all and also breaks the separation of concern between theTaskandRunnerinterfaces.Therefore the method will be removed again.
The text was updated successfully, but these errors were encountered: