Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to golangci-lint version 1.32.0 #20

Closed
svengreb opened this issue Oct 30, 2020 · 0 comments · Fixed by #21
Closed

Update to golangci-lint version 1.32.0 #20

svengreb opened this issue Oct 30, 2020 · 0 comments · Fixed by #21
Labels
context-techstack scope-compatibility scope-quality type-feature
Milestone
0.4.0

Comments

@svengreb
Copy link
Owner

svengreb commented Oct 30, 2020 •
edited
Loading

The currently latest golangci-lint version 1.32.0 introduced new linters that will be added to this template:

  1. wrapcheck — Checks that errors returned from external packages are wrapped.
    This linter is disabled by default, but will be enabled for this template to help tp reduce error context loss.
  2. errorlint — Helps to make more efficient use of the error wrapping scheme introduced in Go 1.13.
    This linter is disabled by default, but will be enabled for this template to help to use Go's new error handling concept.
  3. tparallel — Detects inappropriate usage of t.Parallel() method in Go tests.
    This linter is disabled by default, but will be enabled for this template to help to prevent parallelism errors in tests.
@svengreb svengreb added this to the Next milestone Oct 30, 2020
@svengreb svengreb self-assigned this Oct 30, 2020
svengreb added a commit that referenced this issue Oct 30, 2020
@svengreb
Update to golangci-lint v1.32.0
85a87a9 
The currently latest `golangci-lint` version 1.32.0 [1] introduced new
linters that have been added to this template:

1. wrapcheck [2] — Checks that errors returned from external packages
   are wrapped.
   This linter is disabled by default, but has been enabled for this
   template to help tp reduce error context loss.
2. [errorlint][3] — Helps to make more efficient use of the error
   wrapping scheme introduced in Go 1.13.
   This linter is disabled by default, but has been enabled for this
   template to help to use Go's new error handling concept.
3. [tparallel][4] — Detects inappropriate usage of `t.Parallel()` method
   in Go tests.
   This linter is disabled by default, but has been enabled for this
   template to help to prevent parallelism errors in tests.

[1]: https://github.com/golangci/golangci-lint/releases/tag/v1.32.0
[2]: https://github.com/tomarrell/wrapcheck
[3]: https://github.com/polyfloyd/go-errorlint
[4]: https://github.com/moricho/tparallel

GH-20
@svengreb svengreb mentioned this issue Oct 30, 2020
Merged
svengreb added a commit that referenced this issue Oct 30, 2020
@svengreb
Bump golangci-lint configuration version to 1.32.x
db5c880 
GH-20
svengreb added a commit that referenced this issue Oct 30, 2020
@svengreb
Update to golangci-lint v1.32.0
4ba3beb 
The currently latest `golangci-lint` version 1.32.0 [1] introduced new
linters that have been added to this template:

1. wrapcheck [2] — Checks that errors returned from external packages
   are wrapped.
   This linter is disabled by default, but has been enabled for this
   template to help tp reduce error context loss.
2. [errorlint][3] — Helps to make more efficient use of the error
   wrapping scheme introduced in Go 1.13.
   This linter is disabled by default, but has been enabled for this
   template to help to use Go's new error handling concept.
3. [tparallel][4] — Detects inappropriate usage of `t.Parallel()` method
   in Go tests.
   This linter is disabled by default, but has been enabled for this
   template to help to prevent parallelism errors in tests.

[1]: https://github.com/golangci/golangci-lint/releases/tag/v1.32.0
[2]: https://github.com/tomarrell/wrapcheck
[3]: https://github.com/polyfloyd/go-errorlint
[4]: https://github.com/moricho/tparallel

GH-20
svengreb added a commit that referenced this issue Oct 30, 2020
@svengreb
Update to golangci-lint v1.32.0 (#21)
072aad9 
The currently latest `golangci-lint` version 1.32.0 [1] introduced new
linters that have been added to this template:

1. wrapcheck [2] — Checks that errors returned from external packages
   are wrapped.
   This linter is disabled by default, but has been enabled for this
   template to help tp reduce error context loss.
2. [errorlint][3] — Helps to make more efficient use of the error
   wrapping scheme introduced in Go 1.13.
   This linter is disabled by default, but has been enabled for this
   template to help to use Go's new error handling concept.
3. [tparallel][4] — Detects inappropriate usage of `t.Parallel()` method
   in Go tests.
   This linter is disabled by default, but has been enabled for this
   template to help to prevent parallelism errors in tests.

[1]: https://github.com/golangci/golangci-lint/releases/tag/v1.32.0
[2]: https://github.com/tomarrell/wrapcheck
[3]: https://github.com/polyfloyd/go-errorlint
[4]: https://github.com/moricho/tparallel

Closes GH-20
@svengreb svengreb removed their assignment Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-techstack scope-compatibility scope-quality type-feature
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

Update to golangci-lint v1.32.0 svengreb/tmpl-go
1 participant
@svengreb