Invalid usage of prettier/@typescript-eslint configuration
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of `eslint-config-prettier` [1] version `8.0.0` [2] all configurations have been merged into the `prettier` configuration that now includes not just ESLint core rules, but also rules from all plugins. In GH-32 [3] the `eslint-config-prettier` version was bumped from version v6.0.0 to v8.1.0 [4], but the `@arcticicestudio/eslint-config-typescript` package still explicitly extended the `prettier/@typescript-eslint` configuration which resulted in an error when consuming the package. To fix this problem, the `prettier/@typescript-eslint` has been removed entirely from the `extend` field, leaving only the all-in-one `prettier` configuration. [1]: https://github.com/prettier/eslint-config-prettier [2]: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21 [3]: #32 [4]: prettier/eslint-config-prettier@v6.0.0...v8.1.0 Co-authored-by: Sven Greb <[email protected]> GH-49
svengreb
approved these changes
Apr 8, 2021
arcticicestudio
deleted the
bugfix/gh-49-invalid-usage-prettier-ts-eslint-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #49