React Hooks support and entry point #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All React based "Arctic Ice Studio" projects using at least React version 16.8 (1) that introduced the awesome "Hooks" (2). Since this comes with an entire new API (3) that follows new design/usage pattern, the React team created an official "Hooks" ESLint plugin (4) to help to adhere to the "Rules of Hooks" (5). Since the `@arcticicestudio/eslint-config` package already includes support for React and "JSX A11Y", support for "Hooks" have also been added through a new shareable configuration entry point that - enables the `react-hooks` plugin. - configures both currently available rules `react-hooks/rules-of-hooks` and `react-hooks/exhaustive-deps` rule to `error` level. Since "Hooks" make more use of arrow functions the `react/jsx-no-bind` rule (6) has been adjusted to prevent compatibility problems by setting the `ignoreDOMComponents` and `allowArrowFunctions` options to `true`. Also the `react/display-name` rule has been disabled in order to prevent problems due to missing "display names" for "functional components" that make use of "Hooks" instead of being declared as a class component. The new entry point is available as `@arcticicestudio/eslint-config/react-hooks` and can be composed with all other available entry points (7) to inherit their rules. This feature adds the `eslint-plugin-react-hooks` package as new peer dependency for `@arcticicestudio/eslint-config`. References: (1) https://reactjs.org/blog/2019/02/06/react-v16.8.0.html (2) https://reactjs.org/docs/hooks-intro.html (3) https://reactjs.org/docs/hooks-reference.html (4) https://github.com/facebook/react/tree/master/packages/eslint-plugin-react-hooks (5) https://reactjs.org/docs/hooks-rules.html (6) https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-bind.md (7) https://github.com/arcticicestudio/styleguide-javascript/blob/develop/packages/%40arcticicestudio/eslint-config/README.md#entry-points GH-17
svengreb
approved these changes
Aug 20, 2019
arcticicestudio
deleted the
feature/gh-17-react-hooks-support-entry-point
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17