Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize OS and Go version matrix strategy for CI workflow #13

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Optimize OS and Go version matrix strategy for CI workflow #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 8 additions & 15 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ on: [push]
jobs:
lint-node:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [12.x, 14.x]
steps:
- name: Print metadata and context information
run: |
Expand All @@ -24,19 +21,13 @@ jobs:
- name: "Setup Node.js version ${{ matrix.node-version }}"
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
node-version: "14.x"
- name: Install Node modules
run: yarn --frozen-lockfile
- name: Run linters
run: yarn lint
lint-go:
strategy:
matrix:
# Use the official Go version policy and run for the latest three major version releases.
# See https://golang.org/doc/devel/release.html#policy for more details.
go-version: [1.13.x, 1.14.x, 1.15.x]
os: [macos-latest, ubuntu-latest, windows-latest]
runs-on: ${{ matrix.os }}
runs-on: ubuntu-latest
steps:
- name: Print metadata and context information
run: |
Expand All @@ -45,6 +36,10 @@ jobs:
echo "Workflow Actor: $GITHUB_ACTOR"
- name: Checkout repository
uses: actions/checkout@v2
- name: Install Go
uses: actions/setup-go@v2
with:
go-version: "1.15.x"
- name: "Run golangci-lint"
# The official golangci-lint action created and maintained by the golangci-lint project.
# See https://github.com/golangci/golangci-lint-action for more details.
Expand All @@ -54,10 +49,8 @@ jobs:
test:
strategy:
matrix:
# Use the official Go version policy and run for the latest three major version releases.
# See https://golang.org/doc/devel/release.html#policy for more details.
go-version: [1.13.x, 1.14.x, 1.15.x]
os: [macos-latest, ubuntu-latest, windows-latest]
go-version: ["1.15.x"]
os: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.os }}
needs:
- lint-go
Expand Down