-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cy locale #1103
Add cy locale #1103
Conversation
Ralated to #1006 |
Thank you very much for doing this. I will make sure to review at some point this week 👍 |
@AledBidder I know time is short for everyone, but if you get a chance, could you please take a look at this PR? Thanks a lot! |
I'm considering merging this code as is? Any objection? |
@pama, I'm sorry I haven't had time to conduct a proper review. I've recently had my first child and so time has been in short supply! I have managed to look over everything though and whilst there were small things I would change I don't think there are any glaring mistakes. So I would be happy for this to be merged and then we can always follow up with an additional PR to make small changes if we want to 👍 |
@AledBidder, congratulations on the arrival of your first child! No worries— contributions are always a gift and never an obligation. |
Thank you @pama 🙌 |
@hmzasif could you please fix the conflicts? Thanks! |
@pama, I have removed the conflicts. Thank you! |
Add Welsh(CY) locale
@AledBidder, can you please review this PR to verify the Welsh locale values, especially the unit values for
EB
andPB
? Thanks!