Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cy locale #1103

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Add cy locale #1103

merged 2 commits into from
Dec 10, 2023

Conversation

hmzasif
Copy link
Contributor

@hmzasif hmzasif commented Oct 6, 2023

Add Welsh(CY) locale

@AledBidder, can you please review this PR to verify the Welsh locale values, especially the unit values for EB and PB? Thanks!

@pama
Copy link
Collaborator

pama commented Oct 10, 2023

Ralated to #1006

@AledBidder
Copy link

Thank you very much for doing this. I will make sure to review at some point this week 👍

@pama
Copy link
Collaborator

pama commented Nov 14, 2023

@AledBidder I know time is short for everyone, but if you get a chance, could you please take a look at this PR? Thanks a lot!

@pama
Copy link
Collaborator

pama commented Dec 8, 2023

I'm considering merging this code as is? Any objection?

@AledBidder
Copy link

@pama, I'm sorry I haven't had time to conduct a proper review. I've recently had my first child and so time has been in short supply!

I have managed to look over everything though and whilst there were small things I would change I don't think there are any glaring mistakes. So I would be happy for this to be merged and then we can always follow up with an additional PR to make small changes if we want to 👍

@pama
Copy link
Collaborator

pama commented Dec 8, 2023

@AledBidder, congratulations on the arrival of your first child! No worries— contributions are always a gift and never an obligation.

@AledBidder
Copy link

Thank you @pama 🙌

@pama
Copy link
Collaborator

pama commented Dec 9, 2023

@hmzasif could you please fix the conflicts? Thanks!

@hmzasif
Copy link
Contributor Author

hmzasif commented Dec 10, 2023

@pama, I have removed the conflicts. Thank you!

@pama pama merged commit b469c49 into svenfuchs:master Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants