Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ChromeDriver #26

Open
DavertMik opened this issue Apr 12, 2017 · 7 comments
Open

Include ChromeDriver #26

DavertMik opened this issue Apr 12, 2017 · 7 comments
Labels

Comments

@DavertMik
Copy link

Currently Selenium is usually not enough to launch tests as it may require ChromeDriver or GeckoDriver to work on. Would it be possible for this project to include ChromeDriver as well?

@asgrim
Copy link
Collaborator

asgrim commented Apr 12, 2017

I don't think this is within the scope of this project; it doesn't make sense to bundle any browser-specific driver within. I understand from a convenience point of view, but it would make understanding the release schedules pretty hectic. Which driver(s) would we bundle? Why? How often are they updated (and, by proxy, how often would we have to release). Seems like an unnecessary maintenance burden to me...

@DavertMik
Copy link
Author

I was just looking to something similar to https://www.npmjs.com/package/selenium-standalone and I didn't find any good library in PHP except this one 👍
It would be cool if there was a way for newbies to launch selenium without pain by installing just a single package. Something similar to what Laravel Dusk does.


As for maintenance I think it can be done with a simple PHP script:

  • check for updates
  • download new binaries
  • run basic tests
  • make PR

@asgrim
Copy link
Collaborator

asgrim commented Apr 12, 2017

Something to download the latest driver could be workable, yeah. But I wouldn't bundle the binaries in this repo (as the JAR already is). 👍

@DavertMik
Copy link
Author

Possible solution:

  1. install laravel/dusk,
  2. copy chromedriver out of it
  3. remove laravel dusk
  4. PROFIT
    🤣

@sveneisenschmidt
Copy link
Owner

sveneisenschmidt commented Apr 15, 2017

There could be additional repositories/packages setup to handle this. selenium-driver-chrome, selenium-driver-firefox, ....

We could add them as suggested packages via composer.

@DavertMik
Copy link
Author

Btw there is already an initiative from Joomla you know about. https://github.com/joomla-projects/selenium-server-standalone

Did you have a chance to get more steps into merging the forces?

@sveneisenschmidt
Copy link
Owner

sveneisenschmidt commented Oct 20, 2017

@DavertMik I am open to pursue this further. Thanks for the little push. joomla-projects/selenium-server-standalone#25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants