Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trim SSR'd output more intelligently #998

Merged
merged 34 commits into from
Dec 10, 2017
Merged

trim SSR'd output more intelligently #998

merged 34 commits into from
Dec 10, 2017

Conversation

Rich-Harris
Copy link
Member

fixes #976

@Rich-Harris
start moving logic into Node and its subclasses
2e56d10
@Rich-Harris
remove unused code
4b31992
@Rich-Harris
start implementing build() methods
39f1af2
@Rich-Harris
start moving build logic into individual nodes
8e9e323
@Rich-Harris
move some code around
c6d49b7
@Rich-Harris
remove some unused code
daaad80
@Rich-Harris
move Slot logic
e8e05e7
@Rich-Harris
move attribute logic
425d019
@Rich-Harris
move binding logic
8072f6a
@Rich-Harris
move shared MustacheTag/RawMustacheTag logic
596c432
@Rich-Harris
remove elementStack
56f34c7
@Rich-Harris
remove componentStack
fd24a5c
@Rich-Harris
remove inEachBlock
0cf9259
@Rich-Harris
Merge branch 'master' into gh-979
67aca17
@Rich-Harris
fix a few typescript issues
f4888dd
@Rich-Harris
remove confusing state object from init
7f77a10
@Rich-Harris
remove some unused stuff
f6ac3a4
@Rich-Harris
put namespace on Element nodes
e30dc8e
@Rich-Harris
tidy up
8eacc25
@Rich-Harris
more tidying up
48ed685
@Rich-Harris
simplify
05d63e6
@Rich-Harris
more simplification
16bac3b
@Rich-Harris
rename some stuff to be clearer
433623c
@Rich-Harris
remove unused imports
afa996c
@Rich-Harris
DRY out
e9dc123
@Rich-Harris
more tidying up
ea418cd
@Rich-Harris
rename _block to block
3fa83e3
@Rich-Harris
remove preprocess from ssr renderer
9b2a7e1
@Rich-Harris
more tidying up
e974fdc
@Rich-Harris
small tweak, possibly ahead of a much larger one
a72a6ca
@codecov-io
Copy link

codecov-io commented Dec 10, 2017 •
edited
Loading

Codecov Report

Merging #998 into master will increase coverage by <.01%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #998      +/-   ##
==========================================
+ Coverage   91.99%   91.99%   +<.01%     
==========================================
  Files         115      115              
  Lines        4271     4284      +13     
  Branches     1359     1363       +4     
==========================================
+ Hits         3929     3941      +12     
  Misses        148      148              
- Partials      194      195       +1
Impacted Files Coverage Δ
src/generators/server-side-rendering/index.ts 96.92% <92.85%> (-1.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8eaa7e...3b2404d. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 797165b into master Dec 10, 2017
@Rich-Harris Rich-Harris deleted the gh-976 branch December 10, 2017 15:04
sacrosanctic pushed a commit to sacrosanctic/svelte that referenced this pull request Dec 24, 2024
@github-actions @Rich-Harris
Sync kit docs (sveltejs#998)
a8cff16 
sync kit docs

Co-authored-by: Rich-Harris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove trim() from SSR compiler output
2 participants
@Rich-Harris @codecov-io