Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CSS Nesting implementation #9549

Closed
wants to merge 78 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
78 commits
Select commit Hold shift + click to select a range
4ded50f
Semi working
AlbertMarashi Nov 19, 2023
a3d4eaf
Working CSS nesting implementation
AlbertMarashi Nov 20, 2023
68713ee
Merge branches 'main' and 'main' of https://github.com/sveltejs/svelte
AlbertMarashi Nov 20, 2023
8756de3
Add changeset
AlbertMarashi Nov 20, 2023
2661f4e
Remove some unused testing code
AlbertMarashi Nov 20, 2023
0e67006
Remove unused testing code
AlbertMarashi Nov 20, 2023
d9174c4
Handle rule nesting, remove NestedSelector from SimpleSelector, impro…
AlbertMarashi Nov 20, 2023
b59387b
use for of
AlbertMarashi Nov 20, 2023
fcdc02e
Got CSS combinator prefixes working
AlbertMarashi Nov 27, 2023
dab01b1
closes #9320
AlbertMarashi Nov 27, 2023
05e959c
Implement full CSS nesting support
AlbertMarashi Nov 27, 2023
1ba667d
Update changeset message
AlbertMarashi Nov 27, 2023
b0397d1
Remove some unused code/comments
AlbertMarashi Nov 27, 2023
a37b975
Update .changeset/small-kids-switch.md
AlbertMarashi Nov 27, 2023
48c6cdf
Revert contributor change
AlbertMarashi Nov 29, 2023
2291dc3
Merge branch 'css-nesting' of https://github.com/AlbertMarashi/svelte…
AlbertMarashi Nov 29, 2023
2b4e730
Minor change
AlbertMarashi Nov 29, 2023
b6b872c
Modify comment
AlbertMarashi Nov 29, 2023
a8fb36d
Add additional test fixing bug with multiple nested layers
AlbertMarashi Nov 30, 2023
21d5daf
Merge branch 'main' into css-nesting
AlbertMarashi Jan 31, 2024
92f1e3a
fix syntax error
Rich-Harris Feb 1, 2024
6373f16
Handle CSS nesting by adding invisible selectors before nested rules
AlbertMarashi Feb 3, 2024
b5444cf
Correct comment
AlbertMarashi Feb 3, 2024
7e2875b
Added a failing test
AlbertMarashi Feb 3, 2024
7ea05ce
Merge branch 'main' into pr/9549
Rich-Harris Feb 6, 2024
61497b2
prettier
Rich-Harris Feb 6, 2024
751c73c
partial fix
Rich-Harris Feb 6, 2024
bdccdcb
remove unused export keyword
Rich-Harris Feb 6, 2024
633e05a
move type annotation
Rich-Harris Feb 6, 2024
4d4d973
use NestingSelector everywhere, include in SimpleSelector
Rich-Harris Feb 6, 2024
b884dae
Push some broken code, added block nested groupings
AlbertMarashi Feb 7, 2024
46efb43
Started working on encapsulation logic
AlbertMarashi Feb 7, 2024
0708f16
Wohooo. Almost working
AlbertMarashi Feb 7, 2024
eef0b3b
2 failing tests
AlbertMarashi Feb 7, 2024
8f347a9
Refactor a bunch of code
AlbertMarashi Feb 7, 2024
20629ca
Getting closer
AlbertMarashi Feb 7, 2024
862be02
Even closer
AlbertMarashi Feb 7, 2024
ef4b743
One test left!
AlbertMarashi Feb 7, 2024
1000cdf
Comment out some console.logs
AlbertMarashi Feb 7, 2024
89667b4
All tests passing & clean up a little bit of code
AlbertMarashi Feb 7, 2024
8c81aa7
Rever launch.json changes
AlbertMarashi Feb 8, 2024
51016b5
Add more tests
AlbertMarashi Feb 8, 2024
c1dfaaf
Enhance logic and add some more tests
AlbertMarashi Feb 8, 2024
015e695
Clean some logic
AlbertMarashi Feb 8, 2024
bd37582
Update deprecated function
AlbertMarashi Feb 8, 2024
4b4922e
prettier
Rich-Harris Feb 8, 2024
337b162
merge main
Rich-Harris Feb 9, 2024
055ec38
WIP Test
AlbertMarashi Feb 12, 2024
e075ad7
Merge branch 'css-nesting' of https://github.com/AlbertMarashi/svelte…
AlbertMarashi Feb 12, 2024
a421705
Add test expected result
AlbertMarashi Feb 12, 2024
b9b4cab
Pass all tests
AlbertMarashi Feb 12, 2024
f6a7796
Pass test for invalid characters and simplify block item parse code
AlbertMarashi Feb 12, 2024
fb09917
Add multiple nesting selector support
AlbertMarashi Feb 12, 2024
9c5c05e
Lol wot? Apparently I didn't need that logic
AlbertMarashi Feb 12, 2024
26ba130
Remove some unused logic
AlbertMarashi Feb 12, 2024
2c3cdab
avoid try-catch
Rich-Harris Feb 13, 2024
a528ee6
prettier
Rich-Harris Feb 13, 2024
bb8993b
we really don't need all these tests, it's overkill. one will do. sti…
Rich-Harris Feb 13, 2024
32da098
tweak
Rich-Harris Feb 13, 2024
a46d9fd
unused import
Rich-Harris Feb 13, 2024
1543993
comment out rules with unused/empty children
Rich-Harris Feb 13, 2024
4a7ac18
tweak
Rich-Harris Feb 13, 2024
f03e316
update test
Rich-Harris Feb 13, 2024
a53fa5a
generate wrappers during parse, allow rules to contain atrules
Rich-Harris Feb 13, 2024
67bf628
move grouping logic into Selector
Rich-Harris Feb 14, 2024
3d0a885
shrink things down a touch
Rich-Harris Feb 14, 2024
6e149f2
simplify
Rich-Harris Feb 14, 2024
353d697
simplify
Rich-Harris Feb 14, 2024
84b6f8b
actually we don't need that
Rich-Harris Feb 14, 2024
36123fc
shrink explanation
Rich-Harris Feb 14, 2024
ecff925
move
Rich-Harris Feb 14, 2024
1f23ce5
rename
Rich-Harris Feb 14, 2024
ec49db4
rename
Rich-Harris Feb 14, 2024
f6ba25c
That nested rule wasn't empty
AlbertMarashi Feb 14, 2024
0212055
Merge branch 'css-nesting' of github.com:AlbertMarashi/svelte into pr…
Rich-Harris Feb 14, 2024
4201cf7
revert
Rich-Harris Feb 14, 2024
e3b84d5
merge main
Rich-Harris Feb 14, 2024
d470e13
merge main
Rich-Harris Feb 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/small-kids-switch.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

feat: CSS nesting support
Loading
Loading