-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update Breaking changes section #9444
Conversation
|
@baseballyama is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
sites/svelte-5-preview/src/routes/docs/content/03-appendix/02-breaking-changes.md
Outdated
Show resolved
Hide resolved
…breaking-changes.md Co-authored-by: Ben McCann <[email protected]>
sites/svelte-5-preview/src/routes/docs/content/03-appendix/02-breaking-changes.md
Outdated
Show resolved
Hide resolved
…breaking-changes.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! approved but i added a link to some docs that are added in #9449, so that needs to get merged first
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sites/svelte-5-preview/src/routes/docs/content/03-appendix/02-breaking-changes.md
Outdated
Show resolved
Hide resolved
…breaking-changes.md
Theres no way you get rid of HTML support. WTF. This sucks! What if I don't want to do it Svelte's way? I want HTML back!!!!!!!!!!!!! |
Maybe still we can support it via community level preprocessor. |
I'm stuck with Svelte 4 unless it gets fixed. I'm not rewriting my whole app. Never did I think Svelte would do away with HTML support. That's what a lot of people love about Svelte. Don't get rid of one of Svelte's biggest strengths over other frameworks. It's why I chose Svelte. Why not just bring the feature back instead of a preprocessor? This should have never been removed from Svelte, in my opinion. You all are acting like Svelte has never supported HTML. I thought this was a default for Svelte. I hate the new changes. I've been using Svelte since August 2021 and never had a problem with HTML in Svelte. Please bring this back, and not as a preprocessor. Just bring this feature back in general. |
Related to #9437
I considered allowing event attributes by strings, but I think it was better to mark it as a breaking change because it’s easy to avoid by the following code.
Svelte 5 rewrite
Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (
main
).If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is
svelte-4
and notmain
.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint