fix: Add transform-origin to SVGAttributes #9326
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gives the following error in VS Code
transform-origin
can be set as a presentational attribute but it's missing in theSVGAttributes
.See:
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/transform-origin
https://www.w3.org/TR/SVG2/styling.html#PresentationAttributes (missing in the original spec, I guess it was forgotten)
https://svgwg.org/svg2-draft/styling.html#PresentationAttributes (added in the latest draft)
Do we also need to add transform-origin to packages/svelte/src/compiler/compile/render_dom/wrappers/Element/fix_attribute_casing.js then?
Tests and linting
pnpm test
and lint the project withpnpm lint