-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle patterns in destructured literals #8871
Conversation
Hmm. I have no idea why lint is failing due to some site error since merging in the latest changes from |
That is happening because the get_contributors.js script, when trying to fetch from github, is getting an error response, which is failing in the Array.isArray check. Im sure its no problem, retriggering lint should make it go away |
Yeah, reran it a few minutes ago and the error went away. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm though it should probably get a final approval from someone with more svelte core experience
Co-authored-by: Ben McCann <[email protected]>
f72d5ac
to
bd65818
Compare
fixes #8863
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint