chore: warn about : in attributes and props
#8633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to prevent ambiguity with Svelte directives closes #6823
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benmccann
reviewed
May 25, 2023
benmccann
reviewed
May 25, 2023
| if (this.dependencies.size > 0) { | ||
| parent.cannot_use_innerhtml(); | ||
| parent.not_static_content(); | ||
| } | ||
|
|
||
| // TODO Svelte 5: Think about moving this into the parser and make it an error |
There was a problem hiding this comment.
or should we merge this PR in the Svelte 3 branch and make it an error in Svelte 4?
|
looks like we need to delete the |
|
Ah woops, yeah I deleted that because I first looked into emitting a warning at the parser level but it can only error there, but while looking I saw this seemingly outdated ref thing which looks like a leftover from Svelte 2. If that's the case then yes delete the tests, else I'll revert that |
|
deleted the tests, we definitely don't need to still check for it. if people haven't upgraded from svelte 2 yet then they have bigger concerns 😆 |
5 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to prevent ambiguity with Svelte directives
closes #6823
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests
npm testand lint the project withnpm run lint