docs(site-2): CJS to ESM for code snippets #8449
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| const svelte = require('svelte/compiler'); | ||
| const sass = require('node-sass'); | ||
| import svelte from 'svelte/compiler'; | ||
| import sass from 'node-sass'; |
There was a problem hiding this comment.
Should we maybe update this to use dart-sass? Recommending something as obnoxious as node-sass can't be a good impression
There was a problem hiding this comment.
that's what svelte-preprocess does, so I guess it wouldn't hurt to change for consistency: https://github.com/sveltejs/svelte-preprocess/blob/537b97536c2a48574ca748dccf3fcc0dc6d3ffc5/src/transformers/scss.ts
There was a problem hiding this comment.
svelte preprocess uses a deprecated API of sass, so I tested on staclkblitz with new compileStringAsync API, works, so gonna keep that here https://stackblitz.com/edit/node-ncrbch?file=index.js
There was a problem hiding this comment.
maybe you should send it as a PR to svelte-preprocess as well 😄
| @@ -238,9 +238,9 @@ The `script` and `style` functions receive the contents of `<script>` and `<styl | |||
| If a `dependencies` array is returned, it will be included in the result object. This is used by packages like [rollup-plugin-svelte](https://github.com/sveltejs/rollup-plugin-svelte) to watch additional files for changes, in the case where your `<style>` tag has an `@import` (for example). | |||
There was a problem hiding this comment.
What about vite-plugin-svelte?
There was a problem hiding this comment.
This moves all code snippets to imports rather than the current require. Only exception is svelte/register