feat: search and backlink compatability #8286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dummdidumm
reviewed
Feb 16, 2023
| @@ -0,0 +1,8 @@ | |||
| import { writable } from 'svelte/store'; | |||
| import { persisted } from 'svelte-local-storage-store'; | |||
There was a problem hiding this comment.
Can we use the function from kit.svelte.dev instead of the package?
There was a problem hiding this comment.
I was thinking of moving kit's function to this as well, when I move this to site-kit. Reason: Library is super tiny, and it syncs localstorage as well, so tab synchronisation is also there. It's a nice to have. If you really insist I'll copy paste that function back here
There was a problem hiding this comment.
Sync is a good point, haven't thought of that. Ok with keeping it then.
dummdidumm
approved these changes
Feb 16, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds search to svelte.dev