Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TypeScript 3.9 upgrade #7324

Closed
wants to merge 15 commits into from
Closed

feat: TypeScript 3.9 upgrade #7324

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c17384b
improve types for `createEventDispatcher`
ivanhofer Feb 4, 2022
22aa51d
allow optional parameters for `createEventDispatcher`
ivanhofer Feb 4, 2022
5491871
replace `undefined` with `null`
ivanhofer Feb 5, 2022
d224566
add types tests
ivanhofer Feb 12, 2022
281ee3f
upgrade to typescript `3.9.10`
ivanhofer Feb 12, 2022
49b869b
add some types to `utils.ts`
ivanhofer Feb 12, 2022
4c48f95
add more types
ivanhofer Feb 13, 2022
c2e05e1
Merge branch 'master' into typescript-3.9-upgrade
ivanhofer Feb 22, 2023
c559471
fix types
ivanhofer Feb 23, 2023
c5de00f
fixes
ivanhofer Feb 23, 2023
d8f28f8
remove TODO type
ivanhofer Feb 23, 2023
5f232ae
add more types
ivanhofer Feb 24, 2023
62a62a7
Merge branch 'master' into typescript-3.9-upgrade
dummdidumm Apr 11, 2023
4c7b2d9
bring back some of the typings
dummdidumm Apr 11, 2023
0660873
revert some changes
dummdidumm Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,10 @@
},
"types": "types/runtime/index.d.ts",
"scripts": {
"test": "npm run test:unit && npm run test:integration",
"test": "npm run test:unit && npm run test:integration && npm run test:types",
"test:integration": "mocha --exit",
"test:unit": "mocha --config .mocharc.unit.js --exit",
"test:types": "tsc --project test/types/tsconfig.json --noEmit",
"quicktest": "mocha --exit",
"build": "rollup -c && npm run tsd",
"prepare": "node scripts/skip_in_ci.js npm run build",
Expand Down Expand Up @@ -157,7 +158,7 @@
"sourcemap-codec": "^1.4.8",
"tiny-glob": "^0.2.9",
"tslib": "^2.4.1",
"typescript": "^3.7.5",
"typescript": "^3.9.10",
"util": "^0.12.5"
}
}
1 change: 1 addition & 0 deletions src/compiler/compile/render_dom/invalidate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ export function invalidate(renderer: Renderer, scope: Scope, node: Node, names:
const extra_args = tail.map(variable => get_invalidated(variable)).filter(Boolean);

if (is_store_value) {
// TODO: check why there are 4 parameters, but `set_store_value` only expects 3
return x`@set_store_value(${head.name.slice(1)}, ${node}, ${head.name}, ${extra_args})`;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can someone please confirm that it is wrong to pass 4 arguments?

}

Expand Down
0 src/runtime/ambient.ts → src/runtime/ambient.d.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion src/runtime/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import './ambient';
import './ambient.d.ts';

export {
onMount,
Expand Down
Loading