[fix] Local transitions from #key blocks #7286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfanger
force-pushed
the
fix/local-transition-in-key-block
branch
from
05a5976 to
6676f17
Compare
When adding `|local` to a transition inside a {#key} block, only the outro was triggered not the intro.
This PR fixes sveltejs#5950
tanhauhau
force-pushed
the
fix/local-transition-in-key-block
branch
from
6676f17 to
6544d80
Compare
tanhauhau
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding
|localto a transition inside a {#key} block, only the outro was triggered not the intro.This PR fixes #5950
(The
@transition_inwas missing the local argument inside the generated "key was changed" code)