Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: svelte path not updating #6842

Merged
merged 6 commits into from
Oct 12, 2021

Conversation

RaiVaibhav
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

Fixes: #6834

Print takes the node raw if exists
https://github.com/Rich-Harris/code-red/blob/master/src/print/handlers.js#L1423 else the value and after updating the code-red from "0.1.4" to "0.2.1" this update got missed.

@Conduitry
Copy link
Member

Thanks for the investigation and the fix! I've made a couple of small changes to this - one is to not rewrite the path unless we actually have to - and the other is to simply clear the raw and leave code-red to be responsible for running JSON.stringify on the value.

@RaiVaibhav
Copy link
Contributor Author

Thanks for the refactoring 👍 I follow these patterns next time.

@Conduitry Conduitry merged commit b6b7f5c into sveltejs:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler: sveltePath option is broken
2 participants