Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] add convenience types ComponentType and ComponentProps #6770
[feat] add convenience types ComponentType and ComponentProps #6770
Changes from 17 commits
359b3ec
5fb01cc
3bd3107
2933bff
995c509
a8e616b
5902668
6940665
59638bb
df48d97
7ea67cf
2709f52
6082937
34cb5d2
13cc53c
e38f5b0
472c5a1
1f4190c
a4143c6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file exports an interface
SvelteComponentDev
and a class with the same name. The types of the interface and the class don't match. It was not added in this PR but I find it confusing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also not part of this PR but wouldn't it be better to combine
SvelteComponentDev
andSvelteComponentTyped
. CurrentlySvelteComponentTyped
is justSvelteComponentDev
with some generics that all contain default parameters. When not adding any generics this should result into the same type asSvelteComponentDev