Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] export svelte/ssr in node #6743

Merged
merged 4 commits into from
Sep 22, 2021
Merged

[feat] export svelte/ssr in node #6743

merged 4 commits into from
Sep 22, 2021

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 18, 2021

Credit to @benmccann for the idea. This prevents the need for bundlers to bundle external dependencies that imports svelte in order to resolve them to svelte/ssr.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. It looks like vite-plugin-svelte is the only thing that uses the svelte/ssr export. So if we cut a new release of the plugin that stops using it we could probably remove the svelte/ssr export

@Conduitry
Copy link
Member

Removing svelte/ssr would technically be a breaking change. We don't know what other third-party tooling out there might have started using it. That said, I do think the risk is fairly low, and the it's a question then of how much of a stickler we want to be for semver.

@Conduitry
Copy link
Member

This export map entry is now included in 3.43.0, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants