Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] do not warn if module variables are not the only dependencies in reactive statements #6510

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

tanhauhau
Copy link
Member

#5847 warn that module variables are not reactive when used in a reactive statement

<script context="module">
   let PI = 3.14;
</script>
<script>
  $: twoPi = 2 * PI;
</script>

however this is a valid use case, which should not have warnings:

<script context="module">
   let PI = 3.14;
</script>
<script>
  let r;
  $: area = PI * r * r;
</script>

Before submitting the PR, please make sure you do the following

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@dummdidumm dummdidumm merged commit fd03110 into sveltejs:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants